luminous: rbd: librbd: object map improperly flagged as invalidated #24415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2018 17:39
The HEAD and snapshots have potentially different flag states since object maps get invalidated per revision. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 8620827) Conflicts: src/librbd/ObjectMap.cc: trivial resolution src/librbd/operation/SnapshotRemoveRequest.cc: trivial resolution src/test/librbd/test_DeepCopy.cc: DNE src/test/librbd/test_Migration.cc: DNE
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 5877018) Conflicts: src/librbd/object_map/SnapshotRemoveRequest.cc: trivial resolution src/librbd/object_map/SnapshotRemoveRequest.h: trivial resolution
trociny
reviewed
Oct 4, 2018
| int r = m_image_ctx.get_flags(m_snap_id, &flags); | ||
| assert(r == 0); | ||
| int r = m_image_ctx.get_flags(m_snap_id, &m_flags); | ||
| ceph_assert(r == 0); |
added 3 commits
October 4, 2018 08:05
…istent snapshot If duplicate snapshot remove requests are received by the lock owner from a peer client, the first request will remove the object map. If the second request arrives while the first is in-progress, it will again attempt to remove the object map but fail to load it since it's already been deleted. This incorrectly results in the next object map being flagged as invalid. Fixes: http://tracker.ceph.com/issues/24516 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 0a31c55) Conflicts: src/librbd/object_map/SnapshotRemoveRequest.cc: trivial resolution
The copyup state machine needs to iterate over all object maps to update the existence for the object. If an snapshot is being removed concurrently, it's possible to invalidate the object map for the image. Fixes: http://tracker.ceph.com/issues/24516 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 5a1cb46) Conflicts: src/librbd/ObjectMap.cc: trivial resolution src/librbd/ObjectMap.h: trivial resolution src/librbd/deep_copy/ObjectCopyRequest.cc: moved to rbd-mirror image sync src/librbd/io/CopyupRequest.cc: trivial resolution src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc: moved to rbd-mirror image sync src/test/librbd/test_mock_ObjectMap.cc: trivial resolution
The IO was being unblocked before object map was created, allowing a potential copyup request to fail to update a still-to-be-created object map. Fixes: http://tracker.ceph.com/issues/24516 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 1e87440) Conflicts: src/librbd/object_map/SnapshotCreateRequest.cc: trivial resolution src/librbd/operation/SnapshotCreateRequest.cc: trivial resolution
dillaman
force-pushed
the
wip-36224-luminous
branch
from
61412f9
to
8975ba0
Compare
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/36224